Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: edits #2859

Merged
merged 2 commits into from
Jan 18, 2021
Merged

readme: edits #2859

merged 2 commits into from
Jan 18, 2021

Conversation

coot
Copy link
Contributor

@coot coot commented Jan 12, 2021

Experiment with

and tags. Include all demo applications.

@coot coot added consensus issues related to ouroboros-consensus documentation Network Documentation related tasks networking labels Jan 12, 2021
mrBliss
mrBliss reviewed Jan 12, 2021
View reviewed changes
README.md Outdated
<details>
<summary>
Consensus test components.
</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

I was recently thinking: is this list of commands even useful to have here, I'm not sure we even maintain it. Personally, I wouldn't mind if it were deleted, but others might disagree.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind removing both lists.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anybody of us is regularly using nix-build, it's quite likely that things has changed since these commands where written in the README.md file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I agree. This seems especially sound if running these via cabal inside of nix-shell is close enough to indistinguishable from running them via nix-build. I would think so, except maybe for things like what kind of file handle stdin is (termtype etc). Likely fine.

coot added 2 commits January 12, 2021 17:38
@coot
readme: edits
60d5c58 
Experiment with <details> and <summary> tags. Include all demo
applications.
@coot
readme: removed test commands
8f2db24
@mrBliss mrBliss requested a review from nfrisby January 13, 2021 12:29
nfrisby
nfrisby reviewed Jan 14, 2021
View reviewed changes
README.md Show resolved Hide resolved
@coot
Copy link
Contributor Author

coot commented Jan 18, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 18, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit ca53ae7 into master Jan 18, 2021
@iohk-bors iohk-bors bot deleted the coot/readme branch January 18, 2021 08:58
coot added a commit that referenced this pull request May 16, 2022
@iohk-bors @coot
Merge #2859
9d7fd71 
2859: readme: edits r=coot a=coot

Experiment with <details> and <summary> tags. Include all demo applications.


Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfrisby nfrisby nfrisby approved these changes

@mrBliss mrBliss mrBliss left review comments

Assignees
No one assigned
Labels
consensus issues related to ouroboros-consensus documentation Network Documentation related tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coot @mrBliss @nfrisby