NodeToNode and NodeToClient handshake protocol timeouts #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes 'noTimeLimitsHandshake :: ProtocolLimits'.
coot
added
node-to-client
* 'timeLimitsHandshake' for 'node-to-node': 10s timeout * 'noTimeLimitsHandshake' for node-to-client': no timeout The node-to-client protocol is assumed to be executed in a safe environment, so there's no reason to introduce a timeout. We spotted a handshake timeout on node-to-client protocol in a node that had large valency in a benchmarking cluster. This patch restores node-to-client handshake no timoeut before #2956.
coot
force-pushed
the
coot/local-handshake
branch
from
160826a
to
749715b
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.