Documented GovernorMockEnvironment Generator #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
public root peers are disjoint)
|
Seems like I found a slight bug on the generator, hopefully it is fixed now |
|
Just for reference, the thing I "fixed" was actually intended to be that way, so I'll revert and document the reason for it! |
…l and" This reverts commit 89900fa.
the enforcement of the invariant that says Public/Local Root peer sets to be disjoint.
bolt12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check that local and public root peers are disjoint. Also tried very hard to extend some more governor properties with my new found insights from modelling the Governor with Alloy, and all that I found was this extra harmless check.
Trace properties already check for the validity of the
PeerSelectionStatee, so we can be confident that at least the state is not corrupted after a certain amount of time. I also thought about adding consistency checks for each possible action (i.e. checking if there's no starvation of a particular action), but I am not sure if thelivelockcheck covers that.