consensus: HFC now provides EpochInfo in Except monad #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ledger is about to expect an EpochInfo that can fail. Previously, the ledger did not expect EpochInfo to ever fail, since the ledger only used it under controlled circumstances (ie on slots that Consensus provided). But as of Alonzo, the ledger must apply EpochInfo to slots provided by the user: script transactions have a validity interval specified as a pair of slots. The Plutus interpreter expects the validity interval as a pair of UTC times. Since the user provides the slots, the ledger is now applying EpochInfo in a way that might fail. They want to notice that an invalidate the transaction if so. Hence this commit prepares for that. The HFC has always created EpochInfos that might fail. However, until now it converted those failures to pure exceptions ASAP. As of this commit, the conversion happens at the latest possible moment. And soon a cardano-ledger-specs will allow us to remove the conversion that this commit does just before passing the EpochInfo to the ledger. There are some places in Consensus itself where we continue to use the pure EpochInfo. As before, those places indicate bugs if the error is thrown, so using a pure exception was and still is appropriate.
|
@nc6 @polinavino -- FYI this PR will provide the |
jasagredo
approved these changes
Apr 29, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2126. Also resolves the first draft of CAD-2713 on Jira.
This PR is a single commit; see the message.