-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network Mux Close #3121
Merged
Merged
Network Mux Close #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/network-mux-close
branch
from
May 8, 2021 13:41
224842c
to
7b0d3c0
Compare
njd42
approved these changes
May 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all looking good. The logic of the "group" didn't jump out at me, but thats fine.
karknu
approved these changes
May 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
coot
force-pushed
the
coot/network-mux-close
branch
4 times, most recently
from
May 10, 2021 16:17
b4bcad3
to
abb2be1
Compare
It is useful to tag each job, so we can get statistics on each group or cancel threads that belong to each group seprately.
This prepares for additional context terms needed by the monitor loop.
It is not a clean shutdown if mux stops while any mini-protocol is still runing.
coot
force-pushed
the
coot/network-mux-close
branch
6 times, most recently
from
May 11, 2021 07:11
da752de
to
4452bdf
Compare
The `socket error during receive` test was failing, because it closed the socket before mux started. Add a lock which makes sure that mux is running when we close the socket.
coot
force-pushed
the
coot/network-mux-close
branch
from
May 11, 2021 07:38
4452bdf
to
a4a4c59
Compare
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.