-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetRewardInfoPools
local state query
#3423
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4262998
Add `GetRewardInfoPools` local state query
HeinrichApfelmus 14d47c6
Bump `latestReleasedNodeVersion`
HeinrichApfelmus 906f153
Add entry to the Interface Change Log
HeinrichApfelmus f765ff2
Add `NodeToClientV_11` to cddl
HeinrichApfelmus 2da0d31
Add golden files for CardanoNodeToClientVersion8
HeinrichApfelmus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+39 Bytes
...sus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/ApplyTxErr_Allegra
Binary file not shown.
Binary file added
BIN
+39 Bytes
...nsus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/ApplyTxErr_Alonzo
Binary file not shown.
Binary file added
BIN
+14 Bytes
...ensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/ApplyTxErr_Byron
Binary file not shown.
Binary file added
BIN
+39 Bytes
...sensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/ApplyTxErr_Mary
Binary file not shown.
Binary file added
BIN
+39 Bytes
...sus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/ApplyTxErr_Shelley
Binary file not shown.
Binary file added
BIN
+19 Bytes
...rdano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/ApplyTxErr_WrongEraByron
Binary file not shown.
Binary file added
BIN
+19 Bytes
...ano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/ApplyTxErr_WrongEraShelley
Binary file not shown.
Binary file added
BIN
+1.76 KB
...onsensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Block_Allegra
Binary file not shown.
Binary file added
BIN
+1.83 KB
...consensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Block_Alonzo
Binary file not shown.
Binary file added
BIN
+91 Bytes
...sensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Block_Byron_EBB
Binary file not shown.
Binary file added
BIN
+867 Bytes
...us-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Block_Byron_regular
Binary file not shown.
Binary file added
BIN
+1.85 KB
...s-consensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Block_Mary
Binary file not shown.
Binary file added
BIN
+1.65 KB
...onsensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Block_Shelley
Binary file not shown.
Binary file added
BIN
+801 Bytes
...onsensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/GenTx_Allegra
Binary file not shown.
Binary file added
BIN
+872 Bytes
...consensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/GenTx_Alonzo
Binary file not shown.
Binary file added
BIN
+240 Bytes
...-consensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/GenTx_Byron
Binary file not shown.
Binary file added
BIN
+894 Bytes
...s-consensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/GenTx_Mary
Binary file not shown.
Binary file added
BIN
+687 Bytes
...onsensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/GenTx_Shelley
Binary file not shown.
Binary file added
BIN
+6 Bytes
...est/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Allegra_GetCurrentPParams
Binary file not shown.
Binary file added
BIN
+6 Bytes
...rdano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Allegra_GetEpochNo
Binary file not shown.
Binary file added
BIN
+6 Bytes
...test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Allegra_GetGenesisConfig
Binary file not shown.
Binary file added
BIN
+6 Bytes
...ano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Allegra_GetLedgerTip
Binary file not shown.
Binary file added
BIN
+82 Bytes
.../golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Allegra_GetNonMyopicMemberRewards
Binary file not shown.
Binary file added
BIN
+6 Bytes
.../golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Allegra_GetProposedPParamsUpdates
Binary file not shown.
Binary file added
BIN
+6 Bytes
.../test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Allegra_GetStakeDistribution
Binary file not shown.
Binary file added
BIN
+6 Bytes
...test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Alonzo_GetCurrentPParams
Binary file not shown.
Binary file added
BIN
+6 Bytes
...ardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Alonzo_GetEpochNo
Binary file not shown.
Binary file added
BIN
+6 Bytes
...-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Alonzo_GetGenesisConfig
Binary file not shown.
Binary file added
BIN
+6 Bytes
...dano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Alonzo_GetLedgerTip
Binary file not shown.
Binary file added
BIN
+82 Bytes
...t/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Alonzo_GetNonMyopicMemberRewards
Binary file not shown.
Binary file added
BIN
+6 Bytes
...t/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Alonzo_GetProposedPParamsUpdates
Binary file not shown.
Binary file added
BIN
+6 Bytes
...t/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Alonzo_GetStakeDistribution
Binary file not shown.
Binary file added
BIN
+5 Bytes
...sus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_AnytimeByron
Binary file not shown.
Binary file added
BIN
+5 Bytes
...s-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_AnytimeShelley
Binary file not shown.
Binary file added
BIN
+5 Bytes
...-consensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Byron
Binary file not shown.
Binary file added
BIN
+4 Bytes
...nsensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_HardFork
Binary file not shown.
Binary file added
BIN
+6 Bytes
...o-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Mary_GetCurrentPParams
Binary file not shown.
Binary file added
BIN
+6 Bytes
...-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Mary_GetEpochNo
Binary file not shown.
Binary file added
BIN
+6 Bytes
...no-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Mary_GetGenesisConfig
Binary file not shown.
Binary file added
BIN
+6 Bytes
...ardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Mary_GetLedgerTip
Binary file not shown.
Binary file added
BIN
+82 Bytes
...est/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Mary_GetNonMyopicMemberRewards
Binary file not shown.
Binary file added
BIN
+6 Bytes
...est/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Mary_GetProposedPParamsUpdates
Binary file not shown.
Binary file added
BIN
+6 Bytes
...est/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Mary_GetStakeDistribution
Binary file not shown.
Binary file added
BIN
+6 Bytes
...est/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Shelley_GetCurrentPParams
Binary file not shown.
Binary file added
BIN
+6 Bytes
...rdano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Shelley_GetEpochNo
Binary file not shown.
Binary file added
BIN
+6 Bytes
...test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Shelley_GetGenesisConfig
Binary file not shown.
Binary file added
BIN
+6 Bytes
...ano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Shelley_GetLedgerTip
Binary file not shown.
Binary file added
BIN
+82 Bytes
.../golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Shelley_GetNonMyopicMemberRewards
Binary file not shown.
Binary file added
BIN
+6 Bytes
.../golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Shelley_GetProposedPParamsUpdates
Binary file not shown.
Binary file added
BIN
+6 Bytes
.../test/golden/QueryVersion2/CardanoNodeToClientVersion8/Query_Shelley_GetStakeDistribution
Binary file not shown.
Binary file added
BIN
+40 Bytes
...no-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Allegra_EmptyPParams
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Allegra_EpochNo
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
� |
Binary file added
BIN
+78 Bytes
...o-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Allegra_GenesisConfig
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...rdano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Allegra_LedgerTip
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
�� X �TF����b�Nެ�K��wy�=�Th�|Y |
Binary file added
BIN
+139 Bytes
...st/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Allegra_NonMyopicMemberRewards
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...st/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Allegra_ProposedPParamsUpdates
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
��X��ts.���?9Z�E����P#��2�d | ||
|
1 change: 1 addition & 0 deletions
1
...st/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Allegra_StakeDistribution
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
��X�1���s��]k?�ժ�P�[{%A��X �����-�ò^46���R�>b�{L |
Binary file added
BIN
+63 Bytes
...ano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Alonzo_EmptyPParams
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Alonzo_EpochNo
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
� |
Binary file added
BIN
+78 Bytes
...no-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Alonzo_GenesisConfig
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...ardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Alonzo_LedgerTip
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
�� X ����8����o�fo&&���&n�s�s$&� |
Binary file added
BIN
+139 Bytes
...est/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Alonzo_NonMyopicMemberRewards
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...est/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Alonzo_ProposedPParamsUpdates
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
��X��ts.���?9Z�E����P#��2�� | ||
|
1 change: 1 addition & 0 deletions
1
...est/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Alonzo_StakeDistribution
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
��X�1���s��]k?�ժ�P�[{%A��X �����-�ò^46���R�>b�{L |
Binary file added
BIN
+5 Bytes
...us-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_AnytimeByron
Binary file not shown.
Binary file added
BIN
+15 Bytes
...-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_AnytimeShelley
Binary file not shown.
Binary file added
BIN
+138 Bytes
...consensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Byron
Binary file not shown.
Binary file added
BIN
+19 Bytes
...ardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_EraMismatchByron
Binary file not shown.
Binary file added
BIN
+19 Bytes
...dano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_EraMismatchShelley
Binary file not shown.
Binary file added
BIN
+73 Bytes
...sensus-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_HardFork
Binary file not shown.
Binary file added
BIN
+40 Bytes
...rdano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Mary_EmptyPParams
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...us-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Mary_EpochNo
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
� |
Binary file added
BIN
+78 Bytes
...dano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Mary_GenesisConfig
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Mary_LedgerTip
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
�� X ��E<���p���2W@Y��rJt=&��v��j |
Binary file added
BIN
+139 Bytes
.../test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Mary_NonMyopicMemberRewards
Binary file not shown.
1 change: 1 addition & 0 deletions
1
.../test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Mary_ProposedPParamsUpdates
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
��X��ts.���?9Z�E����P#��2�d | ||
|
1 change: 1 addition & 0 deletions
1
...-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Mary_StakeDistribution
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
��X�1���s��]k?�ժ�P�[{%A��X �����-�ò^46���R�>b�{L |
Binary file added
BIN
+40 Bytes
...no-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Shelley_EmptyPParams
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Shelley_EpochNo
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
� |
Binary file added
BIN
+78 Bytes
...o-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Shelley_GenesisConfig
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...rdano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Shelley_LedgerTip
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
�� X ��� u��'9Ki�(�y���C����)�l |
Binary file added
BIN
+139 Bytes
...st/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Shelley_NonMyopicMemberRewards
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...st/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Shelley_ProposedPParamsUpdates
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
��X��ts.���?9Z�E����P#��2�d | ||
|
1 change: 1 addition & 0 deletions
1
...st/test/golden/QueryVersion2/CardanoNodeToClientVersion8/Result_Shelley_StakeDistribution
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
��X�1���s��]k?�ժ�P�[{%A��X �����-�ò^46���R�>b�{L |
1 change: 1 addition & 0 deletions
1
...ardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/SerialisedBlock_Allegra
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
�O<CARDANO_BLOCK> |
1 change: 1 addition & 0 deletions
1
...cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/SerialisedBlock_Alonzo
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
�O<CARDANO_BLOCK> |
1 change: 1 addition & 0 deletions
1
...dano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/SerialisedBlock_Byron_EBB
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
�O<CARDANO_BLOCK> |
1 change: 1 addition & 0 deletions
1
...-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/SerialisedBlock_Byron_regular
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
�O<CARDANO_BLOCK> |
1 change: 1 addition & 0 deletions
1
...s-cardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/SerialisedBlock_Mary
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
�O<CARDANO_BLOCK> |
1 change: 1 addition & 0 deletions
1
...ardano-test/test/golden/QueryVersion2/CardanoNodeToClientVersion8/SerialisedBlock_Shelley
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
�O<CARDANO_BLOCK> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to refer to what these new queries are?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured that since comments are particularly susceptible to bitrot, it would be best if I mention the specific queries in a single place only, in this case the definition of
ShelleyNodeToClientVersion5
.But I you prefer, I'm happy to the specific query (
GetRewardInfoPools
) at the definition ofCardanoNodeToClientVersion8
as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that makes sense. I'm ok with the comment as is.