Expose transaction size to tx submission #4926
Conversation
crocodile-dentist
force-pushed
the
mwojtowicz/tx-size
branch
2 times, most recently
from
4c167f7
to
6bade12
Compare
crocodile-dentist
force-pushed
the
mwojtowicz/tx-size
branch
2 times, most recently
from
4430a29
to
c82ba98
Compare
crocodile-dentist
added
the
tx-submission
crocodile-dentist
force-pushed
the
mwojtowicz/tx-size
branch
from
c82ba98
to
1658b24
Compare
| -> (tx -> SizeInBytes) -- ^ get size of CBOR encoded transaction | ||
| -> NodeToNodeVersion | ||
| -> ControlMessageSTM m | ||
| -> TxSubmissionClient txid tx m () | ||
| txSubmissionOutbound tracer maxUnacked TxSubmissionMempoolReader{..} _version controlMessageSTM = | ||
| txSubmissionOutbound tracer maxUnacked TxSubmissionMempoolReader{..} _txSize _version controlMessageSTM = |
There was a problem hiding this comment.
Does the outbound side need the callback, or can we use the sizes from the mempool?
Maybe we should change the mempool interface, to give us just [txid]s rather than [(txid, SizeInBytes)] - so we don't have multiple ways of getting that information, possibly in a non-compatible way.
There was a problem hiding this comment.
I've removed the callback from the outbound side. We can keep the interface as-is for now, and if/when the annotated codec gets integrated we can remove SizeInBytes from the mempool API.
| txSubmissionInbound tracer (NumTxIdsToAck maxUnacked) mpReader mpWriter _version = | ||
| txSubmissionInbound tracer (NumTxIdsToAck maxUnacked) mpReader mpWriter _txSize _version = |
There was a problem hiding this comment.
Can we verify the tx sizes using an assert-ion? I'd expect that production nodes run without assertions, and this would give us a chance to verify that this works well.
There was a problem hiding this comment.
Good idea - @karknu commented on slack I think that this maybe should be in an #ifdef.
There was a problem hiding this comment.
I don't think we need CPP for it, assert-tions are only enforced if one compiled the node with -fno-ignore-asserts flag.
crocodile-dentist
changed the base branch from
master
to
coot/tx-submission
crocodile-dentist
force-pushed
the
mwojtowicz/tx-size
branch
2 times, most recently
from
e0a9467
to
7500a79
Compare
crocodile-dentist
force-pushed
the
mwojtowicz/tx-size
branch
2 times, most recently
from
bcf6575
to
0cc240c
Compare
crocodile-dentist
force-pushed
the
mwojtowicz/tx-size
branch
from
0cc240c
to
0cfe8ae
Compare
* Added callback providing tx size to txSubmissionInbound * changelog update
Description
A callback, exposing CBOR-encoded transaction size as it is when transmitted over the network, is provided to
tx submission inbound and outbound handlers. The size returned by this function does not take into account some additional wrapping that happens when a transaction is sent across the network. Namely, it does not include header data for CBOR-in-CBOR encoding (a tag + it's value to indicate a blob payload, and an encodeBytes tag ~ so roughly 3 words) neither the top level header which consists of EncodeListLen tag + it's value, era word tag + era index word, so ~4 words).
IntersectMBO/cardano-ledger#4521
IntersectMBO/ouroboros-consensus#1211
Checklist
Quality
Maintenance
ouroboros-networkproject.