Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature loop improvement #10

Merged
merged 5 commits into from
Aug 17, 2021
Merged

Signature loop improvement #10

merged 5 commits into from
Aug 17, 2021

Conversation

JonasKs
Copy link
Member

@JonasKs JonasKs commented Aug 16, 2021

  • Improve how key to validate token is chosen, based on kid.
  • Add a testcase for when an evil token is provided, but with the correct kid.

- Add a testcase for when an evil token is provided, but with the correct `kid`.
@JonasKs
Copy link
Member Author

JonasKs commented Aug 16, 2021

.. self QA: Could eliminate the need for a loop entirely if we use the kid as a key instead of a value.

fastapi_azure_auth/auth.py Outdated Show resolved Hide resolved
@JonasKs JonasKs merged commit a8f108e into main Aug 17, 2021
@JonasKs JonasKs deleted the improve_signature_loop branch August 27, 2021 14:27
nikstuckenbrock pushed a commit to nikstuckenbrock/fastapi-azure-auth that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant