-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add B2C user docs #140
Conversation
Hi! Thank you so much!😊 I'm out on vacation right now, so the review probably won't come until next week some time. Regarding the errors, it's a bug, we haven't been good enough at testing B2C tokens with the new user model. The fix is to make the |
I have never worked with B2C tokens, but I see Microsoft has a list of the claims in a B2C token. |
Thanks for your quick reply 👍 I could reduce the amount of validation errors to only choke on But with |
Yes, exactly, a PR would be perfect! Both should be optional 😊 |
Codecov Report
@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 6 6
Lines 248 247 -1
=======================================
- Hits 248 247 -1 |
@JonasKs this PR is ready for review. With recent version |
Thank you for your feedback - happy it works😊 This deserve a proper review where I try it out, so I'll make some time next week to do so. |
hi there, did you find the time to take a look at it? disclaimer, I've been using it successfully during development and deployments but have not yet pushed to real users yet. |
Thanks @davidhuser for this amazing work. I'm excited to see this feature @JonasKs |
I'm so sorry, I've struggled to find time, but I should have time next week 😊 |
I'm excited to see this feature @JonasKs |
I'll look at this today, but please note this isn't a feature, it's documentation. You can still use it, even if it's not merged. |
Oh sorry I haven't see that claims tid and oid are now optional and merge are done. |
Correct 😊 |
This looks very good, thank you so much for the time and effort 🙏 Sorry for the late review. I'll merge when you accept / resolve threads. 😊 |
This PR is related to issue #136 and adds the first draft of B2C documentation, based on the single- and multi-tenant setups, with a few necessary changes.
With these documented changes I can already log in via OpenAPI's "Authorize" button.
But when I GET a secured endpoint:
I get the following HTTP 401 error:
tracing to here: https://github.com/Intility/fastapi-azure-auth/blob/main/fastapi_azure_auth/auth.py#L208
is there a setup step I'm missing? Many thanks!