fix: make tid and oid optional to allow User validation in B2C #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, yes the test needs to be updated now, since the model changes. So run the test and see the new output, and update the output to that. The openapi-test reflects the model. 😊 Edit: in other words, update the openapi_scheme variable |
|
@davidhuser It only fails on 2.x because that is the only version of pydantic we run this test on. |
|
No idea why codecov suddenly fails now.. Looks good to me, though! Thanks :) |
JonasKs
approved these changes
Jul 31, 2023
|
I've created a release, will be live when pipelines pass! Thanks for the contribution. https://github.com/Intility/fastapi-azure-auth/releases/tag/4.2.0 |
nikstuckenbrock
pushed a commit
to nikstuckenbrock/fastapi-azure-auth
that referenced
this pull request
Oct 16, 2023
…ity#145) * fix: make and optional to allow User validation in B2C * fix: adjust testing the openapi schema with optional tid and oid claims
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of PR #141 and was recreated to make the PR more straightforward. It makes
tidandoidclaims optional so that B2C auth works.