Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 #200

Merged
merged 9 commits into from
Jul 13, 2024
Merged

v5 #200

merged 9 commits into from
Jul 13, 2024

Conversation

JonasKs
Copy link
Member

@JonasKs JonasKs commented Jul 12, 2024

This PR closes all open issues.

Breaking changes:

  • Azure Entra (previously Active Directory) v1 token support dropped. This is mainly to reduce tests by 30%, and for a use-case I haven't documented, nor recommend anyone to use. If you're on v1 tokens, you should upgrade.
  • Pydantic v1 support dropped. Deprecation warnings fixed, closes [Feature request] support Pydantic v2 syntax / @validator -> @field_validator #150
  • InvalidAuth now takes detail AND request object. Users should be explicit and use InvalidAuthHttp or InvalidAuthWebSocket if they use this class. Example:
-raise InvalidAuth(detail="Missing admin role")
+raise InvalidAuthHttp(detail="Missing admin role")  # for HTTP requests
+raise InvalidAuthWebSocket(detail="Missing admin role")  # for WebSocket requests

Docs:

Feat:

Fix:

TODO:

@JonasKs JonasKs changed the title Docs/lifespan v5 Jul 12, 2024
@JonasKs
Copy link
Member Author

JonasKs commented Jul 12, 2024

Hey @bmoore @dvdalilue and @davidhuser, if you have any time to test this out, please do 😊

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (3ee4443) to head (1662890).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files           6        6           
  Lines         263      266    +3     
=======================================
+ Hits          263      266    +3     
Files Coverage Δ
fastapi_azure_auth/auth.py 100.0% <100.0%> (ø)
fastapi_azure_auth/exceptions.py 100.0% <100.0%> (ø)
fastapi_azure_auth/openid_config.py 100.0% <100.0%> (ø)
fastapi_azure_auth/user.py 100.0% <100.0%> (ø)

@JonasKs

This comment was marked as resolved.

@dvdalilue
Copy link
Contributor

dvdalilue commented Jul 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants