Update the _types module to primitives types

[bmoore]

This is a change in the way the hazmat section of the cryptography module is organized. This fixes the error received when using the most up to date version of cryptography (at the date of writing).

Close #25

[JonasKs]

Probably need to bump cryptography requirement in pyproject.toml.

[JonasKs]

I can see I’ve forgot to write a contributing guide, so pipelines fail on linting. Would you do a pre-commit install and pre-commit run —all-files? That will run all linters(such as isort which is failing)

EDIT: You can use this in the meantime.

Also seems like GitHub action cache is messing up. Could you reset it by changing the -2 to -3 this line?

EDIT2: Ah, seems like you didn’t do the version upgrade through poetry. Please run a poetry update

[bmoore]

I missed the poetry update command. Running that now. I'm not terribly familiar with this development flow. I'll reset the python-jose to reference the extra. What is the reason for keeping it as an extra? Does that define certain optional dependencies?

[JonasKs]

I missed the poetry update command. Running that now. I'm not terribly familiar with this development flow.

No worries, you're quicker to fix things than I am to review, so this has been easy for me 🚀

I'll reset the python-jose to reference the extra. What is the reason for keeping it as an extra? Does that define certain optional dependencies?

Honestly only for clarity, since it supports multiple backends. That way there is no question which one we use.

[codecov]

Codecov Report

Merging #26 (3a824ef) into main (1eec23e) will not change coverage.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files           5        5           
  Lines         174      174           
=======================================
  Hits          174      174           

Impacted Files	Coverage Δ
fastapi_azure_auth/openid_config.py	100.0% <100.0%> (ø)

[JonasKs]

Thank you! I'll release a new version ASAP.

[JonasKs]

Released and on PyPi: https://pypi.org/project/fastapi-azure-auth/

Release tag: https://github.com/Intility/fastapi-azure-auth/releases/tag/3.0.1

[bmoore]

Thank you for all the review and help getting this fix out there!

[JonasKs]

My pleasure 😊