Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Solution for B2C MultiTenant #93

Merged
merged 10 commits into from
Jul 6, 2022
Merged

Conversation

Bulga-xD
Copy link
Contributor

@Bulga-xD Bulga-xD commented Jul 1, 2022

This is a working copy for B2C Multitenant. It's still not perfect but this is not a bad start to push this project forward! Love it! Thanks @JonasKs !

Have to add a couple of more tests in future PRs.

Hope you like it.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #93 (7ab7989) into main (b50f158) will not change coverage.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files           5        5           
  Lines         174      178    +4     
=======================================
+ Hits          174      178    +4     
Impacted Files Coverage Δ
fastapi_azure_auth/__init__.py 100.0% <ø> (ø)
fastapi_azure_auth/auth.py 100.0% <100.0%> (ø)

@JonasKs
Copy link
Member

JonasKs commented Jul 1, 2022

Thank you so much!! I'm so excited to read over this! I'm not on a PC until Sunday, but I'll get back to you early next week😊👏

@JonasKs
Copy link
Member

JonasKs commented Jul 1, 2022

The linting fails, but if you install pre-commit and run it on all your files it should fix itself 😊

See here. pre-commit run --all-files

@Bulga-xD
Copy link
Contributor Author

Bulga-xD commented Jul 1, 2022

Apf, so sorry! 🤣 I won't be so excited... 🤣 It's kind-a trashy but.... just like the project and wants to push it forward! <3

Copy link
Member

@JonasKs JonasKs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phone review 📱

fastapi_azure_auth/auth.py Outdated Show resolved Hide resolved
Copy link
Member

@JonasKs JonasKs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, thank you so much! 😊 I've got some minor nitpick feedback, but good job!!

Please resolve the threads as you work through them. 😊

tests/multi_tenant/conftest.py Outdated Show resolved Hide resolved
tests/multi_tenant/conftest.py Outdated Show resolved Hide resolved
fastapi_azure_auth/auth.py Outdated Show resolved Hide resolved
tests/multi_tenant/conftest.py Show resolved Hide resolved
tests/multi_tenant_b2c/conftest.py Outdated Show resolved Hide resolved
@Bulga-xD Bulga-xD requested a review from JonasKs July 5, 2022 15:43
@JonasKs
Copy link
Member

JonasKs commented Jul 6, 2022

Hey @kristiqntashev, thank you so much! Everything looks great. I'd really love the Azure AD setup to be documented, if you're up to contribute with that too? 😊

I'll release this tomorrow 🚀

@JonasKs JonasKs merged commit 6d0bc53 into Intility:main Jul 6, 2022
@JonasKs
Copy link
Member

JonasKs commented Jul 8, 2022

This has now been released! Thank you so much 🚀 👏

(GitHub release, Pipeline and PyPI release)

nikstuckenbrock pushed a commit to nikstuckenbrock/fastapi-azure-auth that referenced this pull request Oct 16, 2023
Working Solution for B2C MultiTenant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants