-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working Solution for B2C MultiTenant #93
Conversation
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 5 5
Lines 174 178 +4
=======================================
+ Hits 174 178 +4
|
Thank you so much!! I'm so excited to read over this! I'm not on a PC until Sunday, but I'll get back to you early next week😊👏 |
The linting fails, but if you install pre-commit and run it on all your files it should fix itself 😊 See here. |
Apf, so sorry! 🤣 I won't be so excited... 🤣 It's kind-a trashy but.... just like the project and wants to push it forward! <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phone review 📱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, thank you so much! 😊 I've got some minor nitpick feedback, but good job!!
Please resolve the threads as you work through them. 😊
Hey @kristiqntashev, thank you so much! Everything looks great. I'd really love the Azure AD setup to be documented, if you're up to contribute with that too? 😊 I'll release this tomorrow 🚀 |
This has now been released! Thank you so much 🚀 👏 (GitHub release, Pipeline and PyPI release) |
Working Solution for B2C MultiTenant
This is a working copy for B2C Multitenant. It's still not perfect but this is not a bad start to push this project forward! Love it! Thanks @JonasKs !
Have to add a couple of more tests in future PRs.
Hope you like it.