Api/api bukkit #10
Draft
Api/api bukkit #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removing block listener * Removing player listener * Create EntityUtil to extract EntityListener utility methods and remove EntityListener * Removing RedstoneListener * Move util methods to EntityUtil
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR objective is to make the api more flexible to add support for other platforms, mainly sponge.
Possibly also making the Cannon class not strictly bound to its block components.
This is probably a long PR, and is going to break compatibility with most if not all addons, as most people only use movecraft-cannons as an addon, merging movecraft-cannons in the main plugin was a necessary step in order to make this transition seemingless.
While making this some fixes should have been made: