Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Script: PR for Issue 183 #242

Merged
merged 146 commits into from
May 26, 2023
Merged

Conversation

saxenism
Copy link
Contributor

@saxenism saxenism commented May 9, 2023

This PR handles the issue 183 and introduces two separate scripts. One is the deployment script and the other is a setup script.

@saxenism saxenism marked this pull request as draft May 9, 2023 06:45
@FHieser FHieser force-pushed the rahul/issue-183-we-need-setup-scripts branch from 6fd3fe3 to e3924e7 Compare May 22, 2023 13:05
@FHieser FHieser marked this pull request as draft May 22, 2023 13:32
@marvinkruse
Copy link
Member

marvinkruse commented May 22, 2023

Just as a summary, since not everyone was present when we discussed this and when Felix and I had our session.
We rebased everything to main. Since this PR was already 2+ months old, that was quite a pain in the 🍑 😝

@saxenism just FYI: we removed the split/view-version of the MilestoneManager, as it did not even help the contract size at all (due to the inheritance usage, the code of the view contract is copied to the MilestoneManager anyways). Code size of MilestoneManager without the split was 25.832 kB, with your split version, it was 25.833 kB (+1 byte). We reverted it, removed an unused function (an unused budget check), and brought the optimizoooor runs down to 5k from 10k, which reduced the contract size enough to pass the limit with 1-2 % of wiggle room. And your scripts work now with the latest changes from main.

In the future, we will probably look for a more sustainable solution, as the MilestoneManager is currently the only contract of that size, but for now this is fine.

I am currently reviewing the script(s) itself to see if we have all we need. Just tagging @0xNuggan here so you are up to date as well. I will ping everyone once I am happy with everything so the rest can review as well :)

@saxenism
Copy link
Contributor Author

saxenism commented May 23, 2023

Great, although I'm not very sure as to what is happening since I'm pretty sure I already did rebase it and prior to that I kept on merging new changes quite often.

Anyway, happy to know that it's up to date as of now.

Regarding the milestone manager, yeah that's great. Lmk if I can contribute anyhow to the more sustainable solution.

Sure, lmk how the review goes I'll change up things accordingly.

Thanks.

@FHieser FHieser marked this pull request as ready for review May 23, 2023 07:32
scripts/deployment/HowToSetup.md Show resolved Hide resolved
tasks/deployBaseContracts.sh Show resolved Hide resolved
scripts/setup/SetupScript.s.sol Outdated Show resolved Hide resolved
scripts/setup/SetupScript.s.sol Show resolved Hide resolved
@FHieser FHieser merged commit ba70e86 into main May 26, 2023
@marvinkruse marvinkruse deleted the rahul/issue-183-we-need-setup-scripts branch June 14, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants