Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retires feature to serenity client #119

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Add retires feature to serenity client #119

merged 2 commits into from
Aug 24, 2020

Conversation

v1-wizard
Copy link
Contributor

Invictum
Invictum reviewed Aug 24, 2020
View reviewed changes
Copy link
Owner

@Invictum Invictum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v1-wizard thanks for the contributing!

In general PR looks good, but a few points should be discussed / updated. Check individual comments for more details.

@v1-wizard
Fix after code review:
b4de0d7 
* Change method name from `isFailAdded` to `isFailPresent`
* Add NumberFormatException handling to `retriesCount` method
* Write more useful readme
@Invictum Invictum merged commit 4b2b7c8 into Invictum:develop Aug 24, 2020
@v1-wizard v1-wizard deleted the retries-logic branch July 22, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Invictum Invictum Invictum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v1-wizard @Invictum