rsETH/wstETH Market #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
junkim012
commented
Mar 1, 2024
•
junkim012
commented
- Spot and Reserve Oracles for rsETH/wstETH
- UniswapFlashswapDirectMintHandler for rsETH/wstETH
- Deployment Scripts for rsETH/wstETH
build: compile to shanghai instead of paris for push0 support
rsETH/wstETH Market Deployment
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
HrikB
suggested changes
Mar 2, 2024
| import { SafeCast } from "@openzeppelin/contracts/utils/math/SafeCast.sol"; | ||
|
|
||
| /** | ||
| * @notice The weETH spot oracle denominated in wstETH |
There was a problem hiding this comment.
Alter natspec comment from weETH
| ) { | ||
| return 0; // collateral valuation is zero if oracle data is stale | ||
| } else { | ||
| // (ETH / weETH) / (ETH / stETH) = stETH / weETH |
| */ | ||
| function getPrice() public view override returns (uint256) { | ||
| (, int256 ethPerRsEth,, uint256 ethPerRsEthUpdatedAt,) = REDSTONE_RSETH_ETH_PRICE_FEED.latestRoundData(); | ||
| // ETH / weETH [8 decimals] |
feat: UniswapFlashswapDirectMintHandler for rsETH
…on-protocol into jun/rsETH-oracles
… upgrade on block 19366309
HrikB
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.