Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M-04 Fix [PAG] #93

Merged
merged 4 commits into from
May 16, 2024
Merged

M-04 Fix [PAG] #93

merged 4 commits into from
May 16, 2024

Conversation

junkim012
Copy link
Collaborator

No description provided.

@junkim012
fix: divide by zero in interest rate module when totalEthSupply is to…
d9b87b2 
…o small now returns minimum base rate instead of reverting
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented May 12, 2024 •
edited
Loading

M-04 Fix [PAG]

Generated at commit: 27e8d3bc00d8eba40d4334c871e76052771e6923

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
12
39
55
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@junkim012 junkim012 requested a review from HrikB May 12, 2024 07:19
@junkim012
fix: instead of early exit, set utilization rate to zero if totalEthS…
8bdb209 
…upply scaled by distribution factor truncates to zero
@junkim012 junkim012 changed the base branch from jun/lending-vault to jun/PAG-C-01 May 16, 2024 03:38
@junkim012 junkim012 merged commit 226ebd8 into jun/PAG-C-01 May 16, 2024
4 of 6 checks passed
@junkim012 junkim012 deleted the jun/PAG-M-04 branch May 16, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HrikB HrikB Awaiting requested review from HrikB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@junkim012