Develop #37
Merged
Develop #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install all requirements by running: ``` conda env create -f environment.yml --name my_env ```
working requirements in Win
The meta ordering property is now set to "created" for PaperSubmissions. This allows to handle safer the navigation.
Password reset works by displaying the contents of the composed email in the command-line. It does not actually send the email.
when grade inputs are empty this is interpreted as an empty string which differs from the initial value of null, even if they refer to the same situation (no grade assigned). this is handled correctly now.
switching between textarea and select improved. star button, edit button added.
still one needs to add an option to set is_saved to false, improve animation heights and implement the modify-comment text button.
Develop saved comments feature
the new max_question_scores is - "1,1,...,1" for integer points_possible assignments, - str(points_possible) for non-integer points_possible - "0" otherwise New functionality should be added so that the user can quickly change the default max_question_scores for an assignement group. Currently this can be changed only manually via the admin page. Syncing from canvas overrides manually set values if there are no graded submissions for this assignment.
Added file field to the submission canvas both Comments and comment files are displayed added a class method to handle comment files next steps: 1. change the upload location from /submissions/comments to be handled similarly to submission uploads 2. add functionality in upload to canvas 3. make files downloadable when clicked on
- now files are served from the submission detail page - show author, date (, filesize) - fix comment toolbar behavior still work needed to upload files to canvas
Develop comment files
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development of main UI and major changes in all aspects.