adding ref capturing

[choldgraf]

This is a first shot at ref / filepath capturing. Still a WIP but is this in the right direction?

to do:

• Add tests
• Confirm API / naming is 👍

will close #41

[IonicaBizau]

Instead of indexOf(...) != -1 you can do: ["blob", "tree"].includes(splits[2]).

Also, I think & is a typo (unless you really meant it), I assume it should be &&.

Maybe it would be helpful to add the type to the urlInfo (tree or blob).

😁

// Find a better property name maybe
urlInfo.type = splits[2]

Nice work overall! 👍

[choldgraf]

👍 to comments, I think they're all addressed in latest push (+ a test).

LMKWYT!

[choldgraf]

friendly ping! anything else I should do on this one?

[IonicaBizau]

Sorry for delay... some unexpected things happened and I my schedule was modified. 🙈

[IonicaBizau]

Umm, tests are not passing, can you please double-check that?

[choldgraf]

ah oops - github said travis passed so I didn't double-check it, lemme see what's up

[IonicaBizau]

Yes, I noticed that too. It may be because of the node version. I didn’t have time to debug.

…

Sent from my iPhone

On 21 Jan 2018, at 20:45, Chris Holdgraf ***@***.***> wrote: ah oops - github said travis passed so I didn't double-check it, lemme see what's up — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[choldgraf]

oops, I think I missed a >= instead of a >. let's see if tests pass now

[choldgraf]

all travis errors but one are fixed:

["blob","tree"].includes is not a function

looks like a JS version error, yeah?

[choldgraf]

swapped out includes for indexOf and that got the tests passing

[choldgraf]

(I think this is ready to go whenever you are @IonicaBizau :-) )