Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example to docs how to get attr value of root listItem #98

Merged
merged 2 commits into from
Apr 3, 2018
Merged

Add example to docs how to get attr value of root listItem #98

merged 2 commits into from
Apr 3, 2018

Conversation

edorivai
Copy link
Contributor

@edorivai edorivai commented Mar 6, 2018

As explained here: #58 (comment)

IonicaBizau
IonicaBizau requested changes Mar 6, 2018
View reviewed changes
Copy link
Owner

@IonicaBizau IonicaBizau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the example/index.js file as well. Otherwise this will get overridden.

@edorivai
Copy link
Contributor Author

edorivai commented Mar 6, 2018

Ah, the example in the readme is generated from example/index.js?

@IonicaBizau IonicaBizau mentioned this pull request Apr 3, 2018
Merged
@IonicaBizau IonicaBizau merged commit 5041d84 into IonicaBizau:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IonicaBizau IonicaBizau IonicaBizau requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edorivai @IonicaBizau