Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add table header to the notebook cells table #79

Merged
merged 19 commits into from
Nov 15, 2023
Merged

add table header to the notebook cells table #79

merged 19 commits into from
Nov 15, 2023

Conversation

tonyfast
Copy link
Contributor

@tonyfast tonyfast commented Nov 8, 2023

i removed the table header a big ago. it was in the thead element which played tricks on some screen readers. this pull request tests how a normal row in tbody works with voiceover.

  • adds an action to provide a demo link when a pull request is created.

closes #78

@tonyfast tonyfast closed this Nov 8, 2023
@tonyfast tonyfast reopened this Nov 8, 2023
@tonyfast tonyfast closed this Nov 8, 2023
@tonyfast tonyfast reopened this Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

@tonyfast tonyfast closed this Nov 8, 2023
@tonyfast tonyfast reopened this Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

A preview fo the exported examples will be rendered at
https://iota-school.github.io/notebooks-for-all/branch/main/exports/html

@tonyfast tonyfast closed this Nov 8, 2023
@tonyfast tonyfast reopened this Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

A preview fo the exported examples will be rendered at
https://iota-school.github.io/notebooks-for-all/branch/table-headers/exports/html

@tonyfast
Copy link
Contributor Author

tonyfast commented Nov 8, 2023

list and landmark navigation on voiceover ios, but table does not.

@tonyfast
Copy link
Contributor Author

tonyfast commented Nov 8, 2023

hmm. i need to check on NVDA but i dont think the headers are adding any value.

@tonyfast tonyfast merged commit f651fea into main Nov 15, 2023
3 checks passed
@tonyfast
Copy link
Contributor Author

image

this is passing automated axe tests and looks qualitatively good on the w3c validator.

merging

@tonyfast tonyfast mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include time annotations in the document
1 participant