-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Hindi language support #289
Conversation
sourabhsinghrajput45
commented
Sep 30, 2024
- Added Hindi (hi) translations to the project
- Updated supportedLanguages map to include Hindi
- Integrated Hindi translations in the resources object for i18n
Hello @SourabhRajput123 Is anything wrong on our side? Maybe something is not set according to Hacktoberfest rules? |
Hello, @imblowfish Thank you for your message. I apologize for closing the PR; it was due to some confusion on my part. I appreciate your understanding and the opportunity to contribute to the project. If everything looks good, I’d be happy to reopen the PR. Please let me know if there’s anything specific you’d like to discuss! Best regards, |
Hi @imblowfish , Thank you for the thumbs-up on my previous message! I appreciate it. I've reopened the PR and am looking forward to your feedback. Best regards, |
Hello, @SourabhRajput123! Thanks for contributing to the project! It looks like your PR didn't pass the auto checks. This is our first time participating in Hacktoberfest. We have rewritten the If it's not difficult, please fix what is described in sections 8, 10, 11 in CONTRIBUTING.md. Or I can do it myself. |
Hello, @IraSoro Thank you for the feedback! I appreciate the input. This is my first time participating in Hacktoberfest as well, and I’m new to open source. I’ll review the updated CONTRIBUTING.md file and do my best to address the issues in sections 8, 10, and 11. Thanks again for your guidance! Best regards, |
Update datetime.ts
checks done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove unused packages in package.json file
package.json
Outdated
@@ -81,6 +81,7 @@ | |||
] | |||
}, | |||
"devDependencies": { | |||
"@babel/plugin-proposal-private-property-in-object": "^7.21.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this package here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sincerely apologize if I overstepped. I was attempting to troubleshoot a bug that I believed was caused by my local environment. In hindsight, I realize that this package is not necessary for your application, and I apologize once again for any inconvenience caused and for my unintentional unprofessional behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SourabhRajput123, everything looks good! Thanks for fixing that.
Could you also please remove the changes from the package-lock.json
file?
package-lock.json
Outdated
@@ -61,6 +61,7 @@ | |||
"workbox-streams": "^7.0.0" | |||
}, | |||
"devDependencies": { | |||
"@babel/plugin-proposal-private-property-in-object": "^7.21.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all changes to this file.
Hello @SourabhRajput123! If you have any problems with |
Hello! @imblowfish |
@IraSoro could you please update |
@imblowfish, check please. |
@SourabhRajput123, thank you and congratulations on your first contribution to the |