Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hindi language support #289

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Conversation

sourabhsinghrajput45
Copy link
Contributor

  • Added Hindi (hi) translations to the project
  • Updated supportedLanguages map to include Hindi
  • Integrated Hindi translations in the resources object for i18n

@imblowfish
Copy link
Collaborator

imblowfish commented Sep 30, 2024

Hello @SourabhRajput123
Thank you for your contribution
Can you please tell why did you close this PR? Everything looks great.

Is anything wrong on our side? Maybe something is not set according to Hacktoberfest rules?

@sourabhsinghrajput45
Copy link
Contributor Author

Hello, @imblowfish

Thank you for your message. I apologize for closing the PR; it was due to some confusion on my part. I appreciate your understanding and the opportunity to contribute to the project.

If everything looks good, I’d be happy to reopen the PR. Please let me know if there’s anything specific you’d like to discuss!

Best regards,
Sourabh Rajput

@sourabhsinghrajput45
Copy link
Contributor Author

Hi @imblowfish ,

Thank you for the thumbs-up on my previous message! I appreciate it. I've reopened the PR and am looking forward to your feedback.

Best regards,
Sourabh Rajput

@IraSoro IraSoro added this to the vNext milestone Oct 1, 2024
@IraSoro IraSoro linked an issue Oct 1, 2024 that may be closed by this pull request
@IraSoro IraSoro requested review from IraSoro and removed request for IraSoro October 1, 2024 12:18
@IraSoro
Copy link
Owner

IraSoro commented Oct 1, 2024

Hello, @SourabhRajput123! Thanks for contributing to the project!

It looks like your PR didn't pass the auto checks. This is our first time participating in Hacktoberfest. We have rewritten the CONTRIBUTING.md file with more precise instructions.

If it's not difficult, please fix what is described in sections 8, 10, 11 in CONTRIBUTING.md. Or I can do it myself.

@sourabhsinghrajput45
Copy link
Contributor Author

Hello, @IraSoro

Thank you for the feedback! I appreciate the input. This is my first time participating in Hacktoberfest as well, and I’m new to open source. I’ll review the updated CONTRIBUTING.md file and do my best to address the issues in sections 8, 10, and 11.

Thanks again for your guidance!

Best regards,
Sourabh Rajput

Copy link
Collaborator

@imblowfish imblowfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove unused packages in package.json file

package.json Outdated
@@ -81,6 +81,7 @@
]
},
"devDependencies": {
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this package here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sincerely apologize if I overstepped. I was attempting to troubleshoot a bug that I believed was caused by my local environment. In hindsight, I realize that this package is not necessary for your application, and I apologize once again for any inconvenience caused and for my unintentional unprofessional behavior.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SourabhRajput123, everything looks good! Thanks for fixing that.
Could you also please remove the changes from the package-lock.json file?

@@ -61,6 +61,7 @@
"workbox-streams": "^7.0.0"
},
"devDependencies": {
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all changes to this file.

@imblowfish
Copy link
Collaborator

Hello @SourabhRajput123! If you have any problems with package-lock.json changes reverting we can do this ourselves

@sourabhsinghrajput45
Copy link
Contributor Author

Hello! @imblowfish
Thank you for your offer to help. If you’d like, you can go ahead and revert the changes to package-lock.json, as I’m having difficulty doing it myself. I appreciate your assistance!

@imblowfish
Copy link
Collaborator

@IraSoro could you please update package-lock.json? I don't have access to my personal laptop

@IraSoro IraSoro self-requested a review October 8, 2024 22:35
@IraSoro
Copy link
Owner

IraSoro commented Oct 8, 2024

@imblowfish, check please.

@IraSoro IraSoro merged commit 70c9903 into IraSoro:master Oct 9, 2024
1 check passed
@IraSoro
Copy link
Owner

IraSoro commented Oct 9, 2024

@SourabhRajput123, thank you and congratulations on your first contribution to the Peri project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Hacktoberfest: Add translation
3 participants