Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacktoberfest: added support for tagalog translation #293

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

jcgaming-official
Copy link
Contributor

Added my local language which is tagalog.
#279

@IraSoro IraSoro added this to the vNext milestone Oct 1, 2024
@IraSoro IraSoro linked an issue Oct 1, 2024 that may be closed by this pull request
@IraSoro
Copy link
Owner

IraSoro commented Oct 1, 2024

Hello, @jcgaming-official! Thanks for contributing to the project!

It looks like your PR didn't pass the auto checks. This is our first time participating in Hacktoberfest. We have rewritten the CONTRIBUTING.md file with more precise instructions.

If it's not difficult, please fix what is described in sections 8, 9, 10, 11 in CONTRIBUTING.md.

Or I can do it myself. Then please write your locale from those available in the date-fns.

@jcgaming-official
Copy link
Contributor Author

Hello, @jcgaming-official! Thanks for contributing to the project!

It looks like your PR didn't pass the auto checks. This is our first time participating in Hacktoberfest. We have rewritten the CONTRIBUTING.md file with more precise instructions.

If it's not difficult, please fix what is described in sections 8, 9, 10, 11 in CONTRIBUTING.md.

Or I can do it myself. Then please write your locale from those available in the date-fns.

My bad. I'll do it later. Thanks

imblowfish
imblowfish previously approved these changes Oct 15, 2024
@jcgaming-official
Copy link
Contributor Author

image
is it good now? @IraSoro

@jcgaming-official
Copy link
Contributor Author

what im doing wrong here?
image

@imblowfish imblowfish self-requested a review October 15, 2024 12:08
@imblowfish
Copy link
Collaborator

what im doing wrong here?
image

Looks like tl locale is not supported by date-fns library https://github.com/date-fns/date-fns/tree/main/src%2Flocale

@jcgaming-official
Copy link
Contributor Author

what im doing wrong here?
image

Looks like tl locale is not supported by date-fns library https://github.com/date-fns/date-fns/tree/main/src%2Flocale

yes they removed it since 2.29.0 :( date-fns/date-fns#3393 (comment)

@imblowfish
Copy link
Collaborator

Is there some backup locale you use if you don't have Tagalog?

@IraSoro
Copy link
Owner

IraSoro commented Oct 17, 2024

Hello, @jcgaming-official! I read that one of the official languages ​​in the Philippines is English. Since there is no suitable locale in the date-fns library, I decided to leave the enUS locale for now. And I created a task for the future, when the locale is added to the library.
Please write if I'm wrong.

IraSoro
IraSoro previously approved these changes Oct 17, 2024
@IraSoro
Copy link
Owner

IraSoro commented Oct 23, 2024

Hello, @jcgaming-official! I read that one of the official languages ​​in the Philippines is English. Since there is no suitable locale in the date-fns library, I decided to leave the enUS locale for now. And I created a task for the future, when the locale is added to the library. Please write if I'm wrong.

Hello, @jcgaming-official!
I’ve made changes to your PR and want to make sure everything is correct. Can you please check and let me know if it’s OK? If everything is good, I'm ready to merge the PR.
Thanks!

@jcgaming-official
Copy link
Contributor Author

Hello, @jcgaming-official! I read that one of the official languages ​​in the Philippines is English. Since there is no suitable locale in the date-fns library, I decided to leave the enUS locale for now. And I created a task for the future, when the locale is added to the library. Please write if I'm wrong.

Hello, @jcgaming-official!
I’ve made changes to your PR and want to make sure everything is correct. Can you please check and let me know if it’s OK? If everything is good, I'm ready to merge the PR.
Thanks!

Hello @IraSoro , I apologize for my late response. Your changes are everything looks good. I thought I was the only one facing the same issue. I appreciate your effort. Thank you

@IraSoro IraSoro self-requested a review October 25, 2024 10:11
@IraSoro IraSoro merged commit df63aae into IraSoro:master Oct 25, 2024
1 check passed
@IraSoro
Copy link
Owner

IraSoro commented Oct 25, 2024

@jcgaming-official, congratulations on your first contribution to the Peri project, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Hacktoberfest: Add translation
3 participants