Sorted language #318
Merged
Sorted language #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imblowfish
requested changes
Nov 13, 2024
.env
Outdated
| @@ -1,3 +1,4 @@ | |||
| REACT_APP_APP_VERSION=v2.4.2 | |||
| REACT_APP_FEATURE_USE_CUSTOM_VERSION_UPDATE=true | |||
| REACT_APP_FEATURE_DEMO_MODE=false | |||
| REACT_APP_FEATURE_MORE_LANGUAGES=false | |||
There was a problem hiding this comment.
REACT_APP_FEATURE_BETA_LANGUAGES looks more suitable as a name for this variable for me
src/utils/translation.ts
Outdated
| ["vi", "tiếng Việt"], | ||
| ["ta", "தமிழ்"], | ||
| ["hi", "हिन्दी"], | ||
| ["en", "english"], |
There was a problem hiding this comment.
Why English is after the h-letter?
src/utils/translation.ts
Outdated
| ["hi", "हिन्दी"], | ||
| ["en", "english"], | ||
| ["ru", "русский"], | ||
| ...(configuration.features.moreLanguages |
There was a problem hiding this comment.
configuration.features.betaLanguages
added 2 commits
November 14, 2024 16:37
imblowfish
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #300
Closed #314
I sorted the languages in alphabetical order. Added a feature flag for available languages.
And also updated the README.