-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari styling errors #435
Comments
yup so safari just ignores flex gaps until this year, but we probably need to refactor using padding to support older safari. |
Because this is all style related it would be a good first issue for someone, especially if you've used tailwind before. |
Wait this is a terrible issue for you right @franknoirot? don't you run Windows? |
@Irev-Dev I've got a MacBook for work so I think I can do it alright! |
Perfect. |
@Irev-Dev confirmed I've been able to get my dev environment in order and use Redwood's forwarding dev command to open the site running locally from my work computer in Safari. On the hunt for some solutions, think I understand the |
Okay so the problem with the gaps is that the Typically you could use an In the meantime, there is no CSS-only fix for this solution. As noted in the CSSWG thread, Ahmad Shadeed published a JS solution for detecting support in this blog post that explains the detection issue. |
Nice investigative work @franknoirot 🕵️ , Actually would using grid instead of flex work in most of our cases? I don't think we're using flex specific features (like grow/shrink) so maybe that would work? |
@Irev-Dev yeah I'd like to see where I can get away with just converting from One potential reason for using the more bloated detection patch is we can remove that once support is widespread enough and have the best practice already sitting there. And since |
Ugh @Irev-Dev I ran into a problem tonight. At work we keep our laptops up-to-date with the latest iOS (I'm running 14.5) and you can't downgrade, so I'm not able to recreate the I have been able to confirm that replacing Do you know of a reliable way to emulate old desktop Safari versions? |
@franknoirot, but can you reproduce this: ? It happens for me in Safari 14.1.2 (16611.3.10.1.3). |
Oooh, I see now. I don't experience the gap issues either. |
Unless you really want to see this issue to the end @franknoirot, I might as well fix the gap issue since I still got the old version on my machine. Good that the rest of the issues in the IDE are okay in the new version. |
Nice! Appreciate it. |
I've largely neglected safari and the result is there are a bunch of styling problems
Z issues for the login modal
lots of flex gaps ignored by the browser and the page leaves a gap at the bottom of the page.
More ignored gaps.
found by @revolter.
The text was updated successfully, but these errors were encountered: