Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): some callback listeners missing in coreCreateProcessor #416

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix(core): some callback listeners missing in coreCreateProcessor #416

merged 1 commit into from
Jun 27, 2024

Conversation

cyppan
Copy link
Contributor

@cyppan cyppan commented May 31, 2024

While I was trying to monitor subgraphs executions in Langfuse, I figured that the callbacks onGraphStart, onGraphEnd and onGraphError specified in my runGraph options do not work.

It seems they were forgotten in coreCreateProcessor, so I added them.

@abrenneke
Copy link
Collaborator

I didn't notice this, sorry @cyppan! Thank you!

@abrenneke abrenneke merged commit 4329cfd into Ironclad:main Jun 27, 2024
@abrenneke
Copy link
Collaborator

Published 1.18.2 with this fix

@abrenneke
Copy link
Collaborator

@all-contributors please add @cyppan for code

@allcontributors allcontributors bot mentioned this pull request Jun 27, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@abrenneke

I've put up a pull request to add @cyppan! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyppan @abrenneke