Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error location's line is calculated properly even when the newline character is only a carriage return ('\r') #50

Conversation

davidnemeti
Copy link
Contributor

fixes #49

- test CarriageReturn
- test LineFeed
- test CarriageReturn + LineFeed
@yallie yallie merged commit 7320861 into IronyProject:master Jan 27, 2023
@yallie
Copy link
Member

yallie commented Jan 27, 2023

Great! Thank you 👍

@davidnemeti davidnemeti deleted the proper-line-handling-when-only-the-carriage-return-character-is-present-as-newline branch January 27, 2023 15:17
davidnemeti added a commit to davidnemeti/Sarcasm that referenced this pull request Jan 27, 2023
…nuget package

Sarcasm uses Irony through a direct .NET Standard 2.0 dll file instead of a nuget package, until the following pull request are merged, and a new Irony nuget package is published:

IronyProject/Irony#46
IronyProject/Irony#48
IronyProject/Irony#50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants