Check API command length, allow up to 16384 #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the API to ban cpus or irqs, the command can easily be longer than 500, so increase the buffer to 16384, which fits ~3250 cpus or irqs, and add a check to log and exit if it is still not enough. Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
champtar
force-pushed
the
api-command-len
branch
from
f06c358 to
105b155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the API to ban cpus or irqs, the command can easily be longer than 500, so increase the buffer to 16384, which fits ~3250 cpus or irqs, and add a check to log and exit if it is still not enough.
I went the simple route of just bumping the buffer size, tell me if you prefer a recvmsg + realloc loop or ...