Feat: EIP712 verify #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikonieminen
suggested changes
May 17, 2023
mikonieminen
suggested changes
May 17, 2023
bluekirby1111
force-pushed
the
feat/eip712-verify
branch
from
502712b
to
035963a
Compare
Signed-off-by: Blue Kirby <blue.kirby@tutanota.com>
bluekirby1111
force-pushed
the
feat/eip712-verify
branch
from
035963a
to
3b741e5
Compare
| #[test] | ||
| fn test_nested_array() { | ||
| let source = "bytes1[][][7][][][][][][][][]"; | ||
| assert!(parse_type(source).is_err()); |
There was a problem hiding this comment.
Shouldn't this be OK?
Comment on lines
+163
to
+166
| let source = "byte1[][][7][][][][][][][][]"; | ||
| assert!(parse_type(source).is_err()); | ||
| let source = "byte[][][7][][][][][][][][]"; | ||
| assert!(parse_type(source).is_err()); |
There was a problem hiding this comment.
Shouldn't these tests be somewhere else since these test wrong data?
mikonieminen
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation to verify EIP712 signature