#41 restrict encounter types to send #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pmanko
approved these changes
Sep 17, 2021
| @Autowired | ||
| private XdsSenderConfig config; | ||
|
|
||
|
|
||
| @Override | ||
| public List<Message> getNewMessages() { |
There was a problem hiding this comment.
It would be great to test these changes to getNewMessages() - see comment in #45
|
@moshonk I was looking into merging this, and noticed the conflict on XdsExportServiceImpl.java. I don't want to mess anything up with an incorrect merge - would you be able to rebase on main and fix the conflict? |
|
@pmanko conflict resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added provision to set the encounter types to send to the xds repo. By default, only lab encounters allowed(Set via Global Configurations) @ccwhite333 @pmanko @ckemar Awaiting the merging of PR #45