-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pins down grok to 3.1.0 #159
Conversation
I am testing this now |
This worked for me 👍 |
The command line convert statement worked but when I upload a TIF to a media object, I encountered an issue:
Appears to be related to FITS though and I did get JPEG derivs on my media. |
Did you clear your |
It was a fresh clone of the playbook. |
Exactly when did you get this? The FITS module auto-generates a bunch of fields the first time a file type comes through. If you catch it at just the wrong time, maybe it's a timing issue while it's generating a bunch of fields? |
I was trying to view the node page but I can see everything now - node page, media pages, FITS derivative. I think you're right about the timing issue. |
@elizoller, both of you can review it. 🙂 |
thats fancy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR worked as described, I was able to convert a TIF to a JPG via the convert command and via microservice
Thanks for moving this one though. I'll make a ticket for the issue you discovered @elizoller. |
GitHub Issue: Islandora/documentation#1285
Also see islandora-deprecated/ansible-role-grok#8, which updates the default variable in the role to match.
What does this Pull Request do?
Updates Grok to v3.1.0, which does not seg fault when converting tiffs on Ubuntu 18.04 like v2.3.0 does.
How should this be tested?
vagrant up
After it's done building, put a Tiff in your playbook's root directory, ssh in, and run convert on it.
vagrant ssh
cd /home/ubuntu/islandora
convert my.tiff my.jp2
No seg fault! You can run
identify
on the resulting jp2 to confirm it's ok.Interested parties
@Islandora-Devops/committers