Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pins down grok to 3.1.0 #159

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Pins down grok to 3.1.0 #159

merged 1 commit into from
Mar 5, 2020

Conversation

dannylamb
Copy link
Member

@dannylamb dannylamb commented Feb 7, 2020

GitHub Issue: Islandora/documentation#1285

Also see islandora-deprecated/ansible-role-grok#8, which updates the default variable in the role to match.

What does this Pull Request do?

Updates Grok to v3.1.0, which does not seg fault when converting tiffs on Ubuntu 18.04 like v2.3.0 does.

How should this be tested?

  • Pull in this PR
  • vagrant up

After it's done building, put a Tiff in your playbook's root directory, ssh in, and run convert on it.

  • vagrant ssh
  • cd /home/ubuntu/islandora
  • convert my.tiff my.jp2

No seg fault! You can run identify on the resulting jp2 to confirm it's ok.

Interested parties

@Islandora-Devops/committers

@elizoller
Copy link
Member

I am testing this now

@whikloj
Copy link
Member

whikloj commented Mar 4, 2020

This worked for me 👍

@elizoller
Copy link
Member

The command line convert statement worked but when I upload a TIF to a media object, I encountered an issue:

Drupal\Core\Field\FieldException: Attempt to create a field fits_exiftool_compression_scheme that does not exist on entity type media. in Drupal\field\Entity\FieldConfig->getFieldStorageDefinition() (line 312 of /var/www/html/drupal/web/core/modules/field/src/Entity/FieldConfig.php).

Appears to be related to FITS though and I did get JPEG derivs on my media.

@whikloj
Copy link
Member

whikloj commented Mar 4, 2020

Did you clear your roles/external/* directories? I didn't see any errors when I uploaded a Tiff.

@elizoller
Copy link
Member

It was a fresh clone of the playbook.

@dannylamb
Copy link
Member Author

Exactly when did you get this? The FITS module auto-generates a bunch of fields the first time a file type comes through. If you catch it at just the wrong time, maybe it's a timing issue while it's generating a bunch of fields?

@elizoller
Copy link
Member

I was trying to view the node page but I can see everything now - node page, media pages, FITS derivative. I think you're right about the timing issue.
@whikloj are you giving the review or do you want me to do it?

@seth-shaw-unlv
Copy link
Contributor

@elizoller, both of you can review it. 🙂

@elizoller
Copy link
Member

thats fancy

Copy link
Member

@elizoller elizoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR worked as described, I was able to convert a TIF to a JPG via the convert command and via microservice

@dannylamb
Copy link
Member Author

Thanks for moving this one though. I'll make a ticket for the issue you discovered @elizoller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants