Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install taxonomy terms even if theyre duplicates of terms in another vocabulary. #159

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Jun 13, 2024

Addresses #158

  • Adds an id column to the spreadsheet.
  • Uses the id column as the ids: token in the migration's .yml definition
  • Makes nested terms (in LC Resource types) point to their parent with the parent's id.

@rosiel rosiel changed the title Duplicates Install taxonomy terms even if theyre duplicates of terms in another vocabulary. Jun 13, 2024
@jordandukart jordandukart self-assigned this Jun 19, 2024
@rosiel
Copy link
Contributor Author

rosiel commented Jun 19, 2024

From @mjordan, yes, things could get weird in workbench if you have the same term in two places:

If you are including the term name in your input CSV, with no vocab ID namespace in the term data, wb will use the first one in the View lookup and log that it did that. Working from memory here....

Should we include a disclaimer, that when you're setting up your site, maybe delete one of these two competing Resource Types vocabularies?

@mjordan
Copy link
Contributor

mjordan commented Jun 19, 2024

One more point for clarity: if the field references only one vocabulary, Workbench will use that vocabulary ID (from the field's config) to look up the term and will not be aware of identical term names in other vocabs. If the field references multiple vocabs, and the user does not include namespaces, Workbench will complain during --check (and ask you to use namespaces in your input CSV). So things will only get weird if you have a field that references a single vocabulary and that vocabulary contains terms with identical names, or if the field references multiple vocabularies and your CSV includes terms names that are identical but the namespace is the same on the identical names.

@jordandukart
Copy link

[notice] Processed 891 items (891 created, 0 updated, 0 failed, 0 ignored) - done with 'islandora_defaults_tags' does as it says.

@jordandukart jordandukart merged commit e490adf into Islandora-Devops:main Jun 26, 2024
3 checks passed
@jordandukart jordandukart removed their assignment Jun 26, 2024
rosiel added a commit that referenced this pull request Jul 17, 2024
…vocabulary. (#159)

* Add IDs column to migration.

* Use IDs for parents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants