No longer use volume for Matomo install #143
Conversation
|
Not 100% sure if related but seeing something odd in AWS when testing further, putting it into draft until I can confirm it's unrelated. |
|
I can't reproduce the issue I encountered in AWS and I have a sneaking suspicions it was due to my environment configuration rather than this change. That being said please test. |
|
Hi @nigelgbanks curious what action or review is further required here? Should this go into the March / April 2022 - isle-buildkit 1.0.0 release ? |
|
Just needs to be tested & merged, it would be good to get this in prior to the release. |
|
Reporting results from testing process: Test Environment:
Test process / steps
Attempt 1Ran for about ~15 mins with full CPU lockup the entire time. @nigelgbanks Any way we can reduce that? #30 [stage-3 11/11] RUN chmod a=r,u+w /etc/sudo.conf
#30 DONE 1.5s
#31 exporting to image
#31 exporting layers
#31 exporting layers 8.6s done
#31 writing image sha256:f4a0d7565b355033e6039e19c4b4a3e43d48b20266ea99c5bae0f1005f879ec8 done
#31 naming to docker.io/local/code-server:latest done
#31 DONE 8.6s
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':demo:build'.
> Process 'command 'docker'' finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':milliner:build'.
> Process 'command 'docker'' finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================
* Get more help at https://help.gradle.org
BUILD FAILED in 12m 28s
29 actionable tasks: 29 executedAttempt 2
#19 exporting to image
#19 exporting layers
#19 exporting layers 0.5s done
#19 writing image sha256:93387fedb2d06c8ea27d34da39d80312258fb7d3e838715ccf4a8249e6f9a861 done
#19 naming to docker.io/local/solr:latest done
#19 DONE 0.5s
FAILURE: Build completed with 3 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':milliner:build'.
> Process 'command 'docker'' finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':recast:build'.
> Process 'command 'docker'' finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================
3: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':demo:build'.
> Process 'command 'docker'' finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================
* Get more help at https://help.gradle.org
BUILD FAILED in 1m 28s
33 actionable tasks: 7 executed, 26 up-to-date
Attempt 3
> Task :demo:build FAILED
FAILURE: Build completed with 3 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':milliner:build'.
> Process 'command 'docker'' finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':recast:build'.
> Process 'command 'docker'' finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================
3: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':demo:build'.
> Process 'command 'docker'' finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================
* Get more help at https://help.gradle.org
BUILD FAILED in 9s
33 actionable tasks: 4 executed, 29 up-to-date@nigelgbanks I'm not having any luck trying to get this to work? |
Having the code base in a volume makes upgrades and migrations a pain, additionaly the file copies on initial startup can be really slow on NFS drives. Having a volume allows for the dynamic installation of plugins, but then that is specific to that instance, if you were to run a several stage environment dev/stage/prod then one would need to manually check that the plugins exist is each environment. Better would be to extend the image and pack the plugins in with the installation. @see matomo-org/docker#57 @see matomo-org/docker#161
…nistrator for all sites.
Nothing to be done about that, it's due to compiling Imagemagick and a few other things. Normally it'd download a cached version from the server but since this pull request is a year old it's image is not in the remote cache anymore.
Looks to be failing on demo and crayfish based images, mostly likely this is cause they refer to commits in that no longer exists so it's failing to build. I'll rebase main and push. |
nigelgbanks
force-pushed
the
matomo-volume-redux
branch
from
1929635 to
0c6e9de
Compare
|
Bit of a side note when testing you can just pull down the latest commit rather than building locally. Though since this is so old it's probably best to wait for https://github.com/Islandora-Devops/isle-buildkit/runs/5665122574?check_suite_focus=true rather than using the older commit before I just rebased now. |
|
@nigelgbanks I don't think I'm understanding what you mean. What are you recommending I change about the following test steps?
|
|
The pull requests trigger an auto-build and push system so that you can use the commit hash as a |
|
Ah so I can leave out the .gradle bits and go straight to using isle-dc with the resulting commit tag. Hmm I get that but at the same time testing the mechanics of the I'm fine with doing both in this sense. |
Doesn't hurt. It's the same as what Github actions is doing so it can be skipped.
This issue wouldn't have occurred after it was merged. After merging it would be in the same state as my rebase just now. |
Test Environment
Steps taken to test
Results@nigelgbanks Process worked great. Only error worth reporting from https://islandora.traefik.me/admin/reports/status#error is
Should an enduser expect this to work on a local in this manner? I would think yes but I defer to you and @dannylamb for thoughts Should this be a new ticket / issue? |
|
@g7morris not 100% sure but that might be something about the configure in isle-dc, Ya I'd say that'd be a new ticket. It's not really related to Matomo. |
|
Roger that. I'll file a new issue in isle-dc land. Should I be testing logging into Matomo on my local then? Feels like we're almost there but I'm not sure on what to test per se for Matomo specifically? |
|
@g7morris yup that sounds good |
|
Okay I'll just test logging in and see what there is. If it works and I see things, then this should pass. If not, then we'll just discuss and go from there. |
|
Okay new issue filed here Islandora-Devops/isle-dc#241 |
Results@nigelgbanks Can't let this one pass yet as I'm unable to login to Matomo when I navigate to https://islandora.traefik.me/matomo/?module=Login using the following user and password combos
None of the passwords seem to work. As an aside, discussed with @noahwsmith and he is also currently having the same issue with this service and generated secrets / passwords. Can you please review and see what might be blocking this service from accepting the passwords? Not clear if this behavior is the result of the changes or if this has been an issue all along but it is a blocker to testing this PR for sure. Thank you! isle-dcTest Environment
Test process / stepsisle-dcTest Environment
Steps taken to test
|
g7morris
added
bug
|
My issue was unrelated, it turned out. The value in the PASS file for what I was working on reflected a blank NON_HASHED value, rather than the value I thought I was providing. |
|
@g7morris you'll need to test with this branch (which also has some fixes from a previous change to buildkit that needs going in, somehow lost in the fray). Also as @noahwsmith says the password in |
|
@nigelgbanks From your last comment re using a specific branch, I notice that Islandora-Devops/isle-dc#222 has already been merged in as fix, so perhaps enough time has passed along with fixes that I can't test that exactly. I can report that when I run So fixed it appears! Side questionShould I be using If so, then both fail when I run isle-dcTest Environment
Steps taken to test
Results
|
g7morris
removed
bug
|
|
|
@nigelgbanks I can report that when I run So fixed it appears! Merge time? isle-dcTest Environment
Steps taken to test
Results
|
Having the code base in a volume makes upgrades and migrations a pain,
additionaly the file copies on initial startup can be really slow on NFS
drives.
Having a volume allows for the dynamic installation of plugins, but then
that is specific to that instance, if you were to run a several stage
environment dev/stage/prod then one would need to manually check that
the plugins exist is each environment. Better would be to extend the
image and pack the plugins in with the installation.
@see matomo-org/docker#57
@see matomo-org/docker#161
Additionally creates an administrator user per registered site so that they can be managed in an isolated way. These site administrators cannot modify other sites configuration or install plugins on their own. This is the user you should provided to the users of your site.