Explain how Docker Hub factors in the workflow. #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelgbanks
approved these changes
Dec 13, 2021
|
Looks to be something else, for the failed build. Regardless it's not related to this change I'll investigate that separately. |
rosiel
added a commit
that referenced
this pull request
Jan 5, 2022
* Fix logging errors with cantaloupe due to find/replace bug (#165) * Adding max_input_vars to php.ini (#166) * Explain how Docker Hub factors in the workflow. (#171) * Updated the introduction to redirect users to better starting points in case they ended up at this repo by accident. (#164) * [issue-172] Use explicit commits in URLs such that (#176) Code can change when pulling from a master branch, which causes checksum checks to fail. This can changes master to instead refer to explicit commits hashes. The output docker images is byte for byte the same though. * Prevent passwords from being logged. Co-authored-by: dannylamb <dlamb@islandora.ca> Co-authored-by: Rosie Le Faive <lefaive@gmail.com>
rosiel
added a commit
that referenced
this pull request
Feb 10, 2022
* Fix logging errors with cantaloupe due to find/replace bug (#165) * Adding max_input_vars to php.ini (#166) * Explain how Docker Hub factors in the workflow. (#171) * Updated the introduction to redirect users to better starting points in case they ended up at this repo by accident. (#164) * [issue-172] Use explicit commits in URLs such that (#176) Code can change when pulling from a master branch, which causes checksum checks to fail. This can changes master to instead refer to explicit commits hashes. The output docker images is byte for byte the same though. * Prevent passwords from being logged. Co-authored-by: dannylamb <dlamb@islandora.ca> Co-authored-by: Rosie Le Faive <lefaive@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing wording that explains Docker Hub's role in bridging Buildkit and Isle-DC.
Thanks to @adam-vessey and @noahwsmith for answering my question on Slack.