Solr 8.11.2 update

[DonRichards]

This is untested.

I think this would work but I'm still testing it.

[nigelgbanks]

I have a few questions that might affect the upcoming release, and would require us to include some more info in the release notes, or do a minor/major bump.

1. Are any changes required on the Drupal side after this version bump?
2. Will this have an effect on someone's existing index (e.g. their solr-data Docker volume) if they were to switch images.
3. Would they have to rebuild the index if it does?

Thanks!

[nigelgbanks]

Using ENV adds layers to the image and shouldn't be added here. As the environment variables are used for runtime information, not build time.

[DonRichards]

Any suggestions for a replacement? Should I switch it to ARG?

[nigelgbanks]

ARG seems fine, we can change the other images for consistency as part of another issue (I'll create one).

[nigelgbanks]

#245

[DonRichards]

OK, great. Thanks for adding the ticket. Changes made.

[DonRichards]

@nigelgbanks To answer your original questions

1. Are any changes required on the Drupal side after this version bump?

Not sure. It doesn't work for me yet so I imagine it might.

2. Will this have an effect on someone's existing index (e.g. their solr-data Docker volume) if they were to switch images.

I'm glad you asked. I just looked it up here and yes there is. Not sure how to integrate this into the codebase

3. Would they have to rebuild the index if it does?

They suggest always reindexing after an upgrade, I would assume a rebuild would be needed.

With all of that said, I'm not sure what the next steps should be for this PR.

[nigelgbanks]

With all of that said, I'm not sure what the next steps should be for this PR.

At the least, we'll have to include it in the release notes. For isle-dc I'm not certain, there is a good solution as people can / are encouraged to maintain the .env file outside of source control, and we shouldn't be triggering re-builds of indexes if it's not appropriate.

[DonRichards]

Sorry, I just realized I was clicking "Resolved" on your comments as though they were something for me to "resolve". lol

[nigelgbanks]

Sorry, I just realized I was clicking "Resolved" on your comments as though they were something for me to "resolve". lol

Haha no worries, after you have pushed the fix you can mark them as resolved.

[DonRichards]

OK, I think I made all of the suggested changes. But to recap, on the release we should comment on how there is documentation from Solr on how to upgrade the index when upgrading Solr from 7 to 8. We should give an example command that the community has tested to upgrade Solr's index like the example they gave but adjusted for isle-dc

./bin/solr start -c -Dsolr.http1=true -z localhost:2481/solr -s /path/to/solr/home

They also had one last comment that we should probably spell out how to do it manually

When all nodes have been upgraded to 8.0, restart each one without the -Dsolr.http1 parameter.

[DonRichards]

@nigelgbanks Do you see what's making the tests fail? I don't see what I need to change to get it to pass.

[nigelgbanks]

Looks to be the same ps issue:

BusyBox v1.34.1 (2021-11-23 00:57:35 UTC) multi-call binary.

Usage: ps [-o COL1,COL2=HEADER] [-T]

Show list of processes

        -o COL1,COL2=HEADER     Select columns for display
        -T                      Show threads
This script relies on a version of ps that supports the -p flag.

Please install a POSIX compliant version and try again.

Seems that https://issues.apache.org/jira/browse/SOLR-16191 is wrong is stating that it's fixed for 8.11.2.

[nigelgbanks]

Looks like I read the ticket wrong, on reviewing their actual changes made for 8.11.2 it seems like they now have a hard requirement on using GNU version of ps rather than supporting both.

[nigelgbanks]

@DonRichards I've changed this to a draft just to prevent it from going in before we cut a minor release (which should be pretty soon). Subsequently, it should be good to go into the next major release, for which we'll document the need for folks to rebuild their solr index.

[DonRichards]

@nigelgbanks are you good with this dropping the "draft" status now?

[nigelgbanks]

@DonRichards whoops yea we'll start working on the 2.0.0 release.

[nigelgbanks]

@DonRichards I've raised a ticket, so I don't forget about updating the release notes. #261