integrate with renovate #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelgbanks
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
This looks fine to me as far as I can tell. I tried running it, following the instructions in the README. It produced this for some reason: #359, I suspect because this is not merged yet.
Yeah, the renovate JSON config needs to be on the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After putting together the PR for #357 yesterday I wondered if renovate could be used to help find/detect/issue PRs for dependencies in our Dockerfiles. renovate has good support for github tags/releases, which most of our dependencies live at. We can write custom managers for other dependencies, but first thought I'd send this over to see if this is how we want to proceed (i.e. do we want to use renovate for this, or maybe some other tool).
Basically, if this PR is merged we can follow the instructions in the README to update a whole slew of dependencies. If we're in agreement renovate is the preferred approach for this, we can add other dependencies to be checked, and look into automating the PR process. Right now a PR would need created by manually running the renovate CLI on a developer's workstation with the proper dependencies installed and the proper GitHub token. Automating could just be a github action we add the properly scoped token for in a secret that runs on a schedule. We probably should use a robot github account for that.
The PR that will get issued in this repo will look like this: joecorall#12