-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly configured Drupal - Islandora & Drupal installation scripts to be merged #23
Comments
@nikathone Please note, the composer.json and .lock files that are in that directory with @dannylamb 's install-islandora.sh script will be removed from here post-merge as they are just placeholders now. I believe your current drupal_init process in the Makefile and install script pulls from the born-digital Github repo https://github.com/Born-Digital-US/drupal-project which is what we want to preserve. Apologies for confusion but this is also on my radar to fix. Let me know if you need further clarification here. |
After reviewing https://github.com/Islandora-Devops/isle-dc/blob/06b877b0f010ba6d7884b19e2de6f65c39f0a7c6/scripts/islandora/install-islandora.sh to check what we will need to preserve/reuse in the drupal docker entrypoint. I think
echo "Clone drupal-project to /var/www/html"
git clone -b isle8-dev https://github.com/Born-Digital-US/drupal-project.git /var/www/html
chmod 755 /var/www/html/composer.*
# TO DO: mkdir theme dir and other necessary sub-folders
cd /var/www/html || exit
echo "composer update && installing Drupal console"
composer update
chmod u+w web/sites/default
composer require drupal/console:~1.0 --prefer-dist --optimize-autoloader
The
If everybody agree with the above, after #6 merge we can confirm that the configuration starter is complete and create a separate issue if it's not then have a separate issue for point 3 and close this one. Tagging @dannylamb cause we might need his feedback. |
I'm good with pushing all the config and module enabling to core drupal sync machinery. When going dev -> stage -> prod it makes a lot more sense. ...and maybe I'm being paranoid, but let's at least keep a copy of that init script in history. Rather not shoot my future self in the foot when something goes bad and I need to completely rebuild. |
Also depends on #21 |
@dannylamb & @nikathone What are the next steps with this? |
I @dannylamb is working on getting this done |
Remove the "name" module configuraton
Additionally @nikathone has some good thoughts and ideas about work using the drupal image entry-point.sh which he can either open up a new ticket for or add here for further discussion as needed.
The text was updated successfully, but these errors were encountered: