Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to docker-compose down the containers started by running "make starter"? #388

Closed
fishfree opened this issue Apr 24, 2024 · 5 comments
Closed

Comments

@fishfree
Copy link

fishfree commented Apr 24, 2024

I don't find where is the docker-compose.yml generated by the make starter command.

@DonRichards
Copy link
Member

@fishfree In the Makefile it's calling this in multiple places but default runs with every make command. But here is where it's being actually constructed https://github.com/Islandora-Devops/isle-dc/blob/development/Makefile#L252.

In a nutshell

docker compose $(SERVICES:%=-f build/docker-compose/docker-compose.%.yml) config

Docker compose is looking at the build/docker-compose/ directory and merges all of the YML files that use naming convention docker-compose.*.yml.

@fishfree
Copy link
Author

@DonRichards Thank you! So I need to docker-compose down every yaml file in the folder build/docker-compose?

@highermath
Copy link
Contributor

highermath commented Apr 28, 2024 via email

@DonRichards
Copy link
Member

@highermath You're correct. make down runs the docker compose down against the compiled docker-compose.yml.

@fishfree No, you just run it against the docker-compose.yml file if you don't want to run the make down command.

@fishfree
Copy link
Author

fishfree commented May 7, 2024

@highermath @DonRichards Thank you! make down works!

@fishfree fishfree closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants