Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify fcrepo version in docker-compose.yml #20

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Specify fcrepo version in docker-compose.yml #20

merged 1 commit into from
Oct 6, 2023

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented Sep 25, 2023

Without this environment variable set, the milliner container runs logic used against fcrepo v5, but isle-site-template ships with fcrepo 6. Without this environment variable passed to the milliner container, some crayfish derivative services fail in unexpected ways.

Relevant code that sets/references this env var:

@rosiel rosiel self-requested a review September 27, 2023 17:22
Copy link
Contributor

@nigelgbanks nigelgbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't see this sooner, thanks for finding and fixing this!

@nigelgbanks nigelgbanks merged commit a4e7021 into Islandora-Devops:main Oct 6, 2023
@joecorall joecorall deleted the milliner-fcrepo-6 branch October 6, 2023 23:02
@rosiel rosiel removed their request for review October 10, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants