Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use new starter site #10

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Update to use new starter site #10

merged 3 commits into from
Jan 11, 2024

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Nov 14, 2023

Updates the hashes and commits of Workbench, Demo Objects, and Starter Site.

@rosiel rosiel marked this pull request as draft November 14, 2023 15:50
@rosiel
Copy link
Contributor Author

rosiel commented Nov 14, 2023

@nigelgbanks I think the build will fail because of Drush Launcher and Drush 12. That's what seemed to happen on my machine (the drupal container balked and exited). I put it here hoping more eyeballs would see it but it seems that PRs don't trigger a build anymore.

@nigelgbanks
Copy link
Collaborator

I tried locally, and made a few changes to your pull.

Mainly, I changed the source images for isle-buildkit to use the latest release.

ISLANDORA_TAG=2.0.10

And a change to default_settings.txt to account for the changes to the Drupal API.

Followed by:

docker compose build
docker compose pull 

Seems to work.

@rosiel
Copy link
Contributor Author

rosiel commented Nov 17, 2023

With your fixes, it runs! 🥳

I encountered an error w.r.t. IIIF manifest generation that Born Digital has a fix for (thank you!) and I think it'll be worth waiting till the books display in Mirador properly before launching this. Thus, I'm keeping it in draft for now.

@ajstanley ajstanley marked this pull request as ready for review January 9, 2024 20:37
@ajstanley
Copy link
Contributor

ajstanley commented Jan 9, 2024

I saw a few conflicts with the IIIF module. Excerpt from 'Wild flowers of Western Canada' shows JSON errors. This comes from a logic issue which has been fixed (Issue 1000) in main, but not the latest tag.
If we fix that one we get Cantaloupe errors that come from a bad config file. If we set processor.selection_strategy = ManualSelectionStrategy and processor.ManualSelectionStrategy.jp2 = OpenJpegProcessor we get good results.
This was fixed 2 months ago, but still not in a tagged release.

@ajstanley
Copy link
Contributor

I bumped the version to 3.0.7. Mirador books now display properly.
I'll put in a separate ticket to update composer.json, composer.lock and core.ext in config on Starter Site, but this runs well for now.

@nigelgbanks
Copy link
Collaborator

Tested locally and this looks to work well.

@nigelgbanks nigelgbanks merged commit 2422960 into main Jan 11, 2024
@nigelgbanks nigelgbanks deleted the update branch January 11, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants