Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Resolves Islandora/documentation#569
What does this Pull Request do?
Merges the broadcaster and pipeline code to be a single route, where behavior is controlled via a header that gets converted to an
ExchangePattern
.What's new?
We're using the routingSlip pattern for both now. Using an exchange pattern of
InOnly
causes the same message to get passed to each recipient. Processing occurs in parallel. Using the exchange pattern ofInOut
causes the output of each recipient to get passed to the next, with processing occuring in sequence. In other words,InOut
causes each step to 'block', allowing us to control the sequence of steps in a workflow.If no header is provided for the exchange pattern, the default behaviour is to use
InOnly
.How should this be tested?
./gradlew install
/opt/karaf/bin/client
bundle:list | grep islandora
to get the number of theislandora-connector-broadcast
bundlebundle:update THAT_NUMBER
Everything should continue to work as expected. That is, go do some CRUD on an entity and the changes should be reflected in the triplestore.
Additional Notes:
Thanks to @Natkeeran for posing the right questions when working through an earlier issue, as that's what prompted this improvement.
Interested parties
@Islandora-CLAW/committers