Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade symfony to 5.4 & separate EntityMapper #174

Merged
merged 8 commits into from
May 5, 2023

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Apr 19, 2023

GitHub Issue: Islandora/documentation#2220

Relies on

  1. Update dependencies chullo#99
  2. Upgrade 5.4 symfony and pull out EntityMapper Crayfish-Commons#63

What does this Pull Request do?

  • Upgrades Symfony from 4.4 to 5.4
  • Pulls in the updated Crayfish-Commons
  • Disables the ApixMiddleware from Homarus as we pass the URI to ffmpeg anyways
  • Removes Crayfish-Commons dependency from Milliner and passes in chullo and fedora-entity-mapper
  • Updates documentation

What's new?

  • Does this change require documentation to be updated? Included
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

See the full build PR on islandora-playbook here (Islandora-Devops/islandora-playbook#263)

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

whikloj added 3 commits April 19, 2023 09:55
Switch to lexik_jwt_bundle

Milliner need islandora-fedora-entity-mapper but not Crayfish-Commons
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.21 ⚠️

Comparison is base (d4bc375) 76.93% compared to head (bafdd3b) 76.72%.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x     #174      +/-   ##
============================================
- Coverage     76.93%   76.72%   -0.21%     
  Complexity      160      160              
============================================
  Files             6        6              
  Lines           711      782      +71     
============================================
+ Hits            547      600      +53     
- Misses          164      182      +18     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@whikloj
Copy link
Member Author

whikloj commented Apr 26, 2023

Thinking about this I decided to make a new 4.x branch as this changes the version of Symfony and as such would not be a simple overlay. It will require changes to your configuration which I may have to write.

@whikloj whikloj marked this pull request as ready for review April 27, 2023 21:54
@seth-shaw-asu seth-shaw-asu self-requested a review May 3, 2023 17:14
@seth-shaw-asu seth-shaw-asu merged commit c2c44b9 into 4.x May 5, 2023
@whikloj whikloj deleted the upgrade-5.4-symfony branch July 4, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants