Alter Valve to send roles via Http header #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#966
What does this Pull Request do?
It moves all Drupal roles into a Http header that is passed to Fedora using its HeaderProvider.
It assigns a single role of
fedoraUser
orfedoraAdmin
based on whether any of the current user roles matchfedoraAdmin
. Perhaps this should be made configurable in future.Also when we reverted the SynFilter PR, we reverted the change to accept the standard JWT claims. So I have re-added those changes here.
Lastly we were parsing the
syn-settings.xml
file 3 times, I changed the code to accept aConfig
object. So we just parse once to get that object and pass it to get the various maps.What's new?
How should this be tested?
See Islandora-Devops/islandora-playbook#86
Interested parties
@Islandora-CLAW/committers