Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ServiceProvider and ControllerProvider for the Transaction Service #139

Merged
merged 2 commits into from
Feb 9, 2016
Merged

Use ServiceProvider and ControllerProvider for the Transaction Service #139

merged 2 commits into from
Feb 9, 2016

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Feb 5, 2016

This depends on Islandora/chullo#32 to correct the FedoraApi extendTransaction call.

DiegoPino
DiegoPino reviewed Feb 5, 2016
View reviewed changes
services/TransactionService/src/index.php

$app->register($islandoraTransactionService);
$app->mount("/islandora", $islandoraTransactionService);

$app['fedora'] = $app->share(function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whikloj, this line and the two next ones are not needed anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! Yep good catch.

@whikloj
Copy link
Member Author

whikloj commented Feb 5, 2016

One of the things I found confusing was we name one file with Controller but it isn't controlling anything. It's more of a model in the MVC context, like an interaction model. So I wonder if we should name them that way. Then it is clearer (at least to me) that the ServiceProvider defines the service and handles routing and the <insert class name here> handles direct interactions.

Thoughts?

@DiegoPino
Copy link
Contributor

@Islandora-CLAW/7-x-2-x-committers, are you all good with this? I checked and would like to merge (depending one is already merged) so we can keep iterating. Will wait the 24hr span for some comments.

Thanks!

@ruebot
Copy link
Member

ruebot commented Feb 9, 2016

do eeeeeeeeeeeeit!

@daniel-dgi
Copy link
Contributor

Looks good to me.

DiegoPino added a commit that referenced this pull request Feb 9, 2016
@DiegoPino
Merge pull request #139 from whikloj/make_txService_use_providers
edad6b2 
Use ServiceProvider and ControllerProvider for the Transaction Service
@DiegoPino DiegoPino merged commit edad6b2 into Islandora:sprint-002 Feb 9, 2016
@DiegoPino
Copy link
Contributor

Got consensus so merged right away. Thanks @whikloj for this pull

@ruebot ruebot mentioned this pull request Feb 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whikloj @DiegoPino @ruebot @daniel-dgi