-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Videojs #743
base: 2.x
Are you sure you want to change the base?
Videojs #743
Conversation
A few non-code related notes (I'll add code comments separately):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to clean up for coding standards.
|
||
$transcript_urls = array(); | ||
|
||
if ($nid != NULL) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can avoid the Guzzle work by using IslandoraUtils. After you lookup the Term ID, e.g. $transcript_term = getTermForUri('http://pcdm.org/use#Transcript');
, take your $node
from the routeMatch and use getMediaWithTerm to find your Transcript Media, e.g. $media = getMediaWithTerm($node, $transcript);
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Between IslandoraUtils
and the MediaSourceService
you can replace huge chunks of this.
@Natkeeran are you still working on this? |
@Natkeeran I'm keen to see this work make its way into Islandora. Is there anything I can do to help? |
@elizoller, we may need to consider this PR abandoned. I would probably grab my own branch of Islandora, apply this PR's patch file to your branch, and then address the various comments made on this PR to continue cleaning it up before making a new PR. |
ok, thanks for the advice @seth-shaw-unlv |
Is this still going to be merged? |
i contributed the work that uses HTML5 video and audio players instead of videojs. i vaguely remember there may have been some community concern about including videojs when it can cost money. but thats a vague memory so if others know something different, please chime in. |
! Important - This is for review and feedback.
JIRA Ticket: (link)
Use-a-thon: Oral History Transcriptions documentation#1305
Add Captions, Subtitles, and Interactive Transcripts documentation#1003
Drupal core issue about vtt - https://www.drupal.org/project/drupal/issues/3057144
Drupal videojs module issue about audio support - https://www.drupal.org/project/videojs/issues/2698357
What does this Pull Request do?
This PR enables you to add transcript(s) to video/audio objects when using videojs viewer.
What's new?
How should this be tested?
http://localhost:8000/admin/structure/taxonomy/manage/islandora_media_use/overview
(note the path)http://localhost:8000/admin/structure/media/manage/audio/display
andhttp://localhost:8000/admin/structure/media/manage/video/display
Media Use
. Save.Notes and Questions
/taxonomy/term/20
)?Interested parties
@dannylamb @seth-shaw-unlv @DonRichards