Redo of https://github.com/Islandora/islandora/pull/778 and https… #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… master branch.
mjordan
changed the title
|
@mjordan your builds are ok now, right? |
|
Yes, this one built fine. (Edit: It built fine after I merged the 8.x-1.x branch back into my feature branch.) |
elizoller
reviewed
Mar 15, 2021
| else { | ||
| $markup .= '<h3>' . $attr['label'] . ' (' . $entity_type . ') - no RDF type mapping</h3>'; | ||
| } | ||
| $fields = \Drupal::entityManager()->getFieldDefinitions($entity_type, $name); |
There was a problem hiding this comment.
entityManager isn't a think in d9, i believe it'd be entity_field.manager. also it should probably use dependency injection since its in a controller
Merged
|
Superseded by #835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issues: Islandora/documentation#1549 and Islandora/documentation#1550.
What does this Pull Request do?
Accounts for the fact that @mjordan is an idiot. Specifically, this is a redo of the PRs #778 and #782, which I incorrectly opened against and were merged against the master branch.
What's new?
admin/reports/islandora/rdf_mappingsthat generates and renders the report (including updating the menu links and routing YAML files as required)getUriFieldNamesForTerms()function in the Islandora Utilities serviceHow should this be tested?
islandoramodule directory:git remote add mjordan https://github.com/mjordan/islandora.gitgit fetch mjordangit checkout issue-1521-redodrush cr)Additional Notes:
Interested parties
@Islandora/7-x-1-x-committers