Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rdf namespaces into jsonld config (Issue-1520) #832

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Move rdf namespaces into jsonld config (Issue-1520) #832

merged 2 commits into from
Apr 28, 2021

Conversation

seth-shaw-unlv
Copy link

GitHub Issue: Islandora/documentation#1520

Supersedes #831

What does this Pull Request do?

Enables adding RDF namespaces in config.

What's new?

  • Removes hook_rdf_namespaces
  • Adds install and update hooks to add the previously hard-coded namespaces into the jsonld.settings config

How should this be tested?

Test in conjunction with Islandora/jsonld#53.

Interested parties

@Islandora/8-x-committers

@seth-shaw-unlv
Copy link
Author

Note: we will need to merge the JSON-LD PR before Travis is calmed.

@dannylamb
Copy link

Restarting tests now that Islandora/jsonld#53 has been merged.

@seth-shaw-unlv
Copy link
Author

@dannylamb, green means go!

Copy link

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir 🚀

Tested with Islandora/jsonld#53 during the open meeting. Good stuff.

@dannylamb dannylamb merged commit 5644455 into Islandora:8.x-1.x Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants