Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we can connect to the JMS Broker everytime #868

Merged
merged 5 commits into from
May 3, 2022

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Apr 27, 2022

GitHub Issue: Islandora/documentation#2099

What does this Pull Request do?

Specifically checks that the getProtocol() method does not return null which is the root cause of our problems. If it does it tries to disconnect and re-connect which should throw a catchable exception and stop the exploding.

Also, starts using the islandora logger channel instead of the static \Drupal call. This is just code clean-up.

How should this be tested?

  • With an existing Islandora setup
  • Stop ActiveMQ (sudo service stop activemq)
  • Try to add a new taxonomy term to the Language vocabulary.
  • WSOD

Pull in this PR, clear cache and repeat.

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? no one
  • Associated documentation pull request(s): 0_ or documentation issue ___

Additional Notes:

Interested parties

@Islandora/committers, specifically (@jordandukart)

Copy link
Member

@jordandukart jordandukart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin: Unable to connect to JMS Broker, items might not be synchronized to external services..

src/EventGenerator/EmitEvent.php Show resolved Hide resolved
src/EventGenerator/EmitEvent.php Outdated Show resolved Hide resolved
src/EventGenerator/EmitEvent.php Outdated Show resolved Hide resolved
Copy link
Member

@jordandukart jordandukart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go to me, tests are failing because of Islandora/documentation#2093.

@jordandukart
Copy link
Member

@seth-shaw-unlv or @rosiel can you push the button (assuming this is also okay with you)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants