IsIslandora views filter and context condition use Islandora Utils.

[rosiel]

GitHub Issue:

• Allow users to specify what is "In the repository" documentation#1625
• related: Cleary identify 'Islandora' content types in the UI documentation#1255

• and a discussion I had recently with some of the Committers/TAG (sorry, it has slipped my mind)
• And some concerns that I've had recently about Reporting - namely, the abiliity to create a report to show "your islandora content" and not need to update it as you change what content types are islandora.

What does this Pull Request do?

• Creates a Views filter that uses that, so you can make a view for "Islandora nodes" and it won't get out of date when you make new content.
• Notices that there was a Context condition that detected if a node was Islandora, but it did its own testing. Now we just use one test.
• That one test, for the record, relies on (and only on) field_member_of.

• Does this change add any new dependencies? no
• Does this change require any other modifications to be made to the repository
  (i.e. Regeneration activity, etc.)? no
• Could this change impact execution of existing code? If you were using the context condition, AND you have non-islandora nodes using field_member_of, then you have set up a weird repository and you probably want to create your own context conditions.

How should this be tested?

• Create a view and play with the filter.
• Especially create a view that uses relationships and you have to do the filter on a related node.
• Test the context condition similarly.
  They should all be "true" when field_member_of is on the node, and false otherwise.

Documentation Status

• Does this change existing behaviour that's currently documented? Possibly
• Does this change require new pages or sections of documentation? It could - this and the 'missing media' view filter.
• Who does this need to be documented for? site admins using islandora to set up administrative things
• Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@seth-shaw_asu and @Islandora/8-x-committers

[seth-shaw-asu]

The condition works, I actually used it to replace the deprecated condition described in Islandora/documentation#2148.

Unfortunately, the view filter isn't showing up in my filter list. I'll keep poking at it to see if I can figure out why.

Mea cupla, my Isle codebase wasn't updating into my container 🤦‍♂️.... actually testing now.

[seth-shaw-asu]

👍

[seth-shaw-asu]

I thought we had pulled D10 out of the matrix? Should I just ignore those failures and merge, or is there something we need to update in the github workflows files?